Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add street lights to more places, allow deconstructing #3265

Merged

Conversation

chaosvolt
Copy link
Member

Summary

SUMMARY: Content "Allow deconstructing street lights for parts, use them in more locations"

Purpose of change

This aims to make street lights actually show up a reasonable bit in cities, along with giving them so uses beyond just smashing them. Part one of at least three-part plans related to making street lights be a thing and also a useful thing.

Describe the solution

  1. Gave street lights a deconstruction result. Based off what their bash yields return only more and more consistent.
  2. Reduced number of bulbs obtainable from bashing a street light from a max of 3 to a max of 2, for reasons that will be apparent later on.
  3. Added street lights to: Malls, abandoned shopping plazas, abandoned storefronts (excluding meth lab variant), banks, public spaces, home improvement superstores, hospitals, megastores, motels, stadiums, town halls, and zoos. This gives us a start towards street lights in all major shop-type locations, starting with just some of the big main event locations for now.

Describe alternatives you've considered

  1. Reworking road generation code to place street lights there instead. This is easier plus it means less fiddling to get a street light integrated with a working power grid when I get to part three.
  2. Keeping the annoyingly lossy way deconstruction yield tends to be handled. I really don't like doing it that way since it kinda undermines the point of deconstructing stuff instead of bashing them so ech.
  3. Making street lights require advanced deconstruct since big.

Testing

  1. Checked affected files for syntax and lint errors.
  2. Load-tested changes in compiled test build.

Additional context

The other two parts of the plan are:

  1. Mooaaar street lights in basic shop and park locations.
  2. Adding a construction for converting a street light to run off grid power.

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Sep 26, 2023
@github-actions github-actions bot added the mods PR changes related to mods. label Sep 26, 2023
Copy link
Member

@scarf005 scarf005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the Screenshots

Cataclysm: Bright Nights - dc43e235355_01
Cataclysm: Bright Nights - dc43e235355_02
image
image
image
image

could you provide screenshots or a zip file containing world with all new changed buildings spanwned nearby? next time

LGTM

@scarf005 scarf005 added this pull request to the merge queue Sep 26, 2023
Merged via the queue into cataclysmbnteam:upload with commit 1efef0f Sep 26, 2023
11 of 12 checks passed
@chaosvolt chaosvolt deleted the this-machine-attracts-moths branch September 26, 2023 14:35
scarf005 pushed a commit to scarf005/Cataclysm-BN that referenced this pull request Sep 28, 2023
…am#3265)

* Add street lights to more places, allow deconstructing

* Update furniture-terrains.json

* Update megastore.json

* Update homeimprovement_superstore_new.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format. mods PR changes related to mods.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants